add setFeeCollector #776
Merged
add setFeeCollector #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @param _newFeeCollector new fee collector | ||
| */ | ||
|
|
||
| function setFeeCollector(address _newFeeCollector) external onlyERC20Deployer{ |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions
alexcos20
changed the base branch from
v2.0
to
issue779-use-timestamp-instead-of-block-number-in-predictoor
|
Should we remove other stuff related to dispensers? There are some variables and functions, such as: https://github.com/oceanprotocol/contracts/blob/a0ccf2b33d58d11ddcaf1d329971610a2782ca5f/contracts/templates/ERC20Template3.sol#L896C1-L898C6 |
I would keep that to make it compatible with the other two templates |
trizin
approved these changes
Aug 1, 2023
alexcos20
merged commit 796fe91
into
issue779-use-timestamp-instead-of-block-number-in-predictoor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #772
Changes proposed in this PR:
Since contract size exceeded 24k, I also had to :